Skip to content

Fix e2e tests #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 1 commit into from
Oct 11, 2022
Merged

Fix e2e tests #1323

artonge merged 1 commit into from
Oct 11, 2022

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Oct 10, 2022 •
edited
Loading

  • Correctly assign value in AlbumMapper.php
  • Refactor cypress login/log out commands
  • Change user naming logic in e2e tests
  • Refactor how we detect the presence of a shared album in e2e tests

@artonge
Fix e2e tests
b93db5f 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews labels Oct 10, 2022
@artonge artonge added this to the Nextcloud 26 milestone Oct 10, 2022
@artonge artonge self-assigned this Oct 10, 2022
@artonge
Copy link
Collaborator Author

artonge commented Oct 10, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 10, 2022
@artonge artonge marked this pull request as ready for review October 10, 2022 18:34
@artonge artonge requested a review from skjnldsv October 10, 2022 18:35
@artonge artonge merged commit 80144d5 into master Oct 11, 2022
@artonge artonge deleted the artonge/fix/shared_albums_e2e_tests branch October 11, 2022 07:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 11, 2022
Merged
1 task
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge @skjnldsv