Prevent building prefixPath on loading #1371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <[email protected]>
Collaborator
Author
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
Member
|
Won't that go 💥 if we throw? |
Collaborator
Author
Same if we don't, but at least there is an error message, no ? |
skjnldsv
reviewed
Oct 18, 2022
| import { getCurrentUser } from '@nextcloud/auth' | ||
|
|
||
| export const rootPath = 'dav' | ||
| export const prefixPath = `/files/${getCurrentUser().uid}` |
Member
There was a problem hiding this comment.
What about just
Suggested change
| export const prefixPath = `/files/${getCurrentUser().uid}` | |
| export const prefixPath = `/files/${getCurrentUser()?.uid}` |
And we don't touch the other files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1341 as
currentUseris null on public pages