Remove broken icons.css references #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @nicokaiser, indeed, thanks for the fix :) Can you fix DCO ? https://github.com/nextcloud/photos/pull/1454/checks?check_run_id=9283127442 |
Signed-off-by: Nico Kaiser <[email protected]>
nicokaiser
force-pushed
the
fix/icons-css
branch
from
4cb334b to
4ace266
Compare
Contributor
Author
Sorry, I forgot to include the Signed-off-by trailer, fixed it now. |
skjnldsv
approved these changes
Nov 8, 2022
skjnldsv
added
the
4. to release
Collaborator
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
|
Just as an FYI this was causing a 502 within my setup, I did a separate install, same configuration and it only returned 404, not sure why. Took me a few days to find this issue to resolve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadContactsFilesActions adds the "icons" style, which does not exist anymore.
Also, the
css/icons.scssfile seems to be completely unused, so I removed it. Please correct me if I am wrong.This should fix #1451