Disable download from albums #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
artonge
requested review from
Pytal,
skjnldsv and
szaimen
and removed request for
a team
Contributor
|
@artonge I suppose the correct fix would be much work? |
Collaborator
Author
Yes, sadly, it would involve a plugin system to download files, as the current download API is not able to check whether a file is accessible from an album. |
szaimen
approved these changes
Feb 21, 2023
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
All right! LGTM for now then but didnt test
artonge
force-pushed
the
artonge/fix/disable_download_from_album
branch
from
3306e01 to
06a342d
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/disable_download_from_album
branch
from
06a342d to
d33bf56
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #1394