[stable25] Improve overall preview loading #1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
Pytal,
artonge,
skjnldsv and
szaimen
Collaborator
|
/compile amend / |
artonge
approved these changes
Feb 27, 2023
nextcloud-command
force-pushed
the
backport/1647/stable25
branch
from
7f9a3c8 to
5ce8276
Compare
Pytal
approved these changes
Feb 28, 2023
Member
|
/rebase |
This PR improve on the logic to display previews: 1. Append the etag of the file to the file request. This ensure that old cache will not be used if the image is updated 2. Listen to 'files:file:updated' to refetch the file's info and have the new etag 3. Distinguish onload and on error events of the small and large previews to have a finer rendering conditions. Mostly not rendering both previews if the larger one is loaded. 4. Do not delay rendering of files to make the UI snappier Signed-off-by: Louis Chemineau <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
artonge
force-pushed
the
backport/1647/stable25
branch
from
5ce8276 to
4105b48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1647