Skip to content

Install php deps on dev setup #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
May 9, 2023
Merged

Install php deps on dev setup #1777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Install php deps on dev setup 
Currently the dev setup in readme does not mention that a
`composer install` is required but it is. The effect is that,
the plugin can't be activated on the admin figures this out and
makes the install.

Signed-off-by: fenn-cs <[email protected]>
  • Loading branch information
@nfebe
nfebe committed May 9, 2023
commit 7703c9b0ca6e9b4a714a30ecd86897826fc132cc
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
all: dev-setup lint build-js-production test

# Dev env management
dev-setup: clean clean-dev npm-init
dev-setup: clean clean-dev npm-init composer-install

npm-init:
npm ci
Expand Down Expand Up @@ -50,3 +50,6 @@ clean:
clean-dev:
rm -rf node_modules

# Install php deps
composer-install:
composer install