Skip to content

[stable26] Use display name instead of id for shared albums #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 3 commits into from
May 15, 2023
Merged

[stable26] Use display name instead of id for shared albums #1783

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f238b90
Use label instead of id in collaborator form
artonge May 10, 2023
17bbb0c
Use display name instead of id in share album title
artonge May 10, 2023
2282b19
Compile assets
artonge May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use label instead of id in collaborator form 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed May 15, 2023
commit f238b900637d872d6f4e87d4742b04ed0d82c638
4 changes: 2 additions & 2 deletions src/components/Albums/CollaboratorsSelectionForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<li v-for="collaboratorKey of searchResults" :key="collaboratorKey">
<NcListItemIcon :id="availableCollaborators[collaboratorKey].id"
class="manage-collaborators__form__list__result"
:title="availableCollaborators[collaboratorKey].id"
:title="availableCollaborators[collaboratorKey].label"
:search="searchText"
:user="availableCollaborators[collaboratorKey].id"
:display-name="availableCollaborators[collaboratorKey].label"
Expand All @@ -75,7 +75,7 @@
class="manage-collaborators__selection__item">
<NcListItemIcon :id="availableCollaborators[collaboratorKey].id"
:display-name="availableCollaborators[collaboratorKey].label"
:title="availableCollaborators[collaboratorKey].id"
:title="availableCollaborators[collaboratorKey].label"
:user="availableCollaborators[collaboratorKey].id">
<NcButton type="tertiary"
:aria-label="t('photos', 'Remove {collaboratorLabel} from the collaborators list', {collaboratorLabel: availableCollaborators[collaboratorKey].label})"
Expand Down