fix: properly handle public link share deletion #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsejet
added
bug
IShare::getSharedWith returns null for public links, and so AlbumMapper::removeFileWithOwner throws a TypeError (500) Signed-off-by: Varun Patil <[email protected]>
pulsejet
force-pushed
the
pulsejet/fix-link-del
branch
from
1536dfb to
ed48a3f
Compare
artonge
approved these changes
May 22, 2023
Collaborator
|
/backport to stable27 |
backportbot-nextcloud
bot
added
the
backport-request
Collaborator
|
/backport to stable26 |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Collaborator
|
Ah, not applicable to stable26, so not backporting |
Collaborator
|
/backport to stable26 |
backportbot-nextcloud
bot
removed
the
backport-request
Collaborator
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IShare::getSharedWithreturns null for public links, and soAlbumMapper::removeFileWithOwnerthrows a TypeError (500)