Prevent error on generating thumbnails

[adriano-pinaffo]

When generating the thumbnails the parsing throws an error if the file property representing the image size metadata is an empty string. This protects the string by making it be a "{}" if the string is empty. This is described in #1833.

[marcelklehr]

I've recently fixed a bug in recognize that would cause this, so this might not be necessary, but we can add it for good measure.

[artonge]

@marcelklehr can you point to the fix and @adriano-pinaffo can you check if this fix the issue for you?
I would rather fix the issue than silent the error.

[marcelklehr]

here you go: nextcloud/recognize@0fdb558

[adriano-pinaffo]

@artonge @marcelklehr it seems it won't fix the issue because my FacePhoto.php's getMetadata() is already returning the data JSON encoded. See below:

[marcelklehr]

@adriano-pinaffo Could you disable recognize to check whether this bug stems from recognize then?

[adriano-pinaffo]

I disabled Recognize, went back to Photos and CTRL+F5 it... still, Images are not shown

[SeanDS]

@marcelklehr I had this issue with Photos before installing Memories. Since installing Memories I am able to view the photos there but not in the Photos app.

It might be useful to note, that I only started to get this issue in Photos after I ran files:scan, files:repair-tree, files:cleanup and files:scan-app-data operations with occ after I manually modified the file system. This is probably related.

[SeanDS]

Update: I fixed it by running occ files:scan --all then occ files:scan --all --generate-metadata, also having updated to 26.0.1 to 26.0.5.

[AndyScherzinger]

@artonge what do you think still needed or fixed and can be closed?

[artonge]

The code has changed since then. I don't see how the error could occur at the time, and don't see how it could occur now. Feel free to reopen if needed.