Skip to content

show title and close of modal inline #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 2 commits into from
Dec 6, 2023
Merged

show title and close of modal inline #2175

artonge merged 2 commits into from
Dec 6, 2023

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 5, 2023 •
edited
Loading

Close #2174

Before After
image image
image image

@szaimen szaimen added enhancement New feature or request design Related to the design 2. developing Work in progress accessibility labels Dec 5, 2023
@szaimen szaimen added this to the Nextcloud 29 milestone Dec 5, 2023
@szaimen szaimen mentioned this pull request Dec 5, 2023
Closed
@szaimen szaimen force-pushed the enh/noid/show-inline branch from 4db1edb to ee7668b Compare December 5, 2023 12:29
@szaimen szaimen force-pushed the enh/noid/show-inline branch from ee7668b to 46fb961 Compare December 5, 2023 12:52
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2023
@szaimen szaimen marked this pull request as ready for review December 5, 2023 12:54
@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2023

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 5, 2023
@artonge
Copy link
Collaborator

artonge commented Dec 6, 2023

/compile /

@artonge artonge enabled auto-merge December 6, 2023 09:30
@szaimen
Copy link
Contributor Author

szaimen commented Dec 6, 2023

/compile

1 similar comment
@szaimen
Copy link
Contributor Author

szaimen commented Dec 6, 2023

/compile

@nextcloud-command
chore(assets): Recompile assets
8f1196e 
Signed-off-by: nextcloud-command <[email protected]>
@szaimen
Copy link
Contributor Author

szaimen commented Dec 6, 2023

/backport 46fb961 to stable28

@artonge artonge merged commit 334f080 into master Dec 6, 2023
@artonge artonge deleted the enh/noid/show-inline branch December 6, 2023 14:53
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 6, 2023
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Dec 6, 2023
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

No one assigned

Labels

3. to review Waiting for reviews accessibility design Related to the design enhancement New feature or request

Projects

None yet

Milestone

Nextcloud 29

6 participants

@szaimen @artonge @Pytal @ShGKme @nextcloud-command