Skip to content

[stable28] Various fix from 30 #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 7 commits into from
Jul 4, 2024
Merged

[stable28] Various fix from 30 #2518

artonge merged 7 commits into from
Jul 4, 2024

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Jul 4, 2024 •
edited
Loading

Manual partial backport of #2514

Leaving out

  • fix: Populate photosLocationFolder on init - no needed
  • chore: Fix typo in collection.js - not visible
  • chore: Use NcSelect label - no error in the browser console
  • fix: Don't proceed with album creation if it fails - 29 does not need the extra error handling
  • chore: Explicitly require @nc/router - only to make linter happy, so superfluous
  • fix: Specify a source for the tmp local album - no error in the browser console
  • fix: Declare photosLocationFolder as computed - not needed
  • fix: Reinit the files in File.vue - not needed

@artonge artonge self-assigned this Jul 4, 2024
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Jul 4, 2024
@artonge artonge requested a review from nfebe July 4, 2024 15:49
@artonge artonge added this to the Nextcloud 28.0.8 milestone Jul 4, 2024
@artonge artonge merged commit cf0bf4e into stable28 Jul 4, 2024
@artonge artonge deleted the artonge/backport/2514/stable28 branch July 4, 2024 16:11
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebe nfebe nfebe approved these changes

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket

Projects

None yet

Milestone

Nextcloud 28.0.8

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge @nfebe