Skip to content

fix(dashboard): Fix ID and provide icon url #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Jul 11, 2024
Merged

fix(dashboard): Fix ID and provide icon url #2542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(dashboard): Fix ID and provide icon url 
Signed-off-by: Joas Schilling <coding@schilljs.com>
  • Loading branch information
@nickvergessen
nickvergessen committed Jul 11, 2024
commit 99919d0f9139df8b4cc8527d4b1c57fac0da6b7a
15 changes: 11 additions & 4 deletions lib/Dashboard/OnThisDay.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@

use OCA\Photos\AppInfo\Application;
use OCP\AppFramework\Services\IInitialState;
use OCP\Dashboard\IWidget;
use OCP\Dashboard\IIconWidget;
use OCP\IL10N;
use OCP\IURLGenerator;
use OCP\Util;

class OnThisDay implements IWidget {
class OnThisDay implements IIconWidget {
public function __construct(
private IL10N $l,
private IURLGenerator $url,
Expand All @@ -24,7 +24,7 @@ public function __construct(
* @inheritDoc
*/
public function getId(): string {
return 'photos.onthisday';
return 'photos-onthisday';
}

/**
Expand All @@ -48,11 +48,18 @@ public function getIconClass(): string {
return 'icon-calendar-dark';
}

/**
* @inheritDoc
*/
public function getIconUrl(): string {
return $this->url->getAbsoluteURL($this->url->imagePath('core', 'places/calendar.svg'));
}

/**
* @inheritDoc
*/
public function getUrl(): ?string {
return $this->url->linkToRoute('photos.page.indexthisday');
return $this->url->linkToRouteAbsolute('photos.page.indexthisday');
}

/**
Expand Down