fix(folders): empty content and unknown folder render #2577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
bug
skjnldsv
requested review from
a team,
AndyScherzinger,
Pytal,
artonge and
susnux
AndyScherzinger
approved these changes
Aug 8, 2024
Member
Author
|
/compile / |
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
skjnldsv
force-pushed
the
fix/folders-empty
branch
from
f859412 to
1856574
Compare
susnux
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am hit by #2067
On first load, the folders is failing, if you switch views and go back to folder, it works again.
This is a reactivity issue, and I couldn't fix it. Switching to pinia is my recommendation, but this cannot happen in feature freeze.
In any case, this make sure we at least render proper errors without throwing and making the app unusable