perf: group icons into one chunk and extract CSS #2949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2949 +/- ##
======================================
Coverage 2.31% 2.31%
======================================
Files 98 98
Lines 6190 6190
Branches 112 112
======================================
Hits 143 143
Misses 6047 6047 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ferdinand Thiessen <[email protected]>
reducing files from 73 to 56 Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
commented
Apr 23, 2025
| [[annotations]] | ||
| path = ["l10n/**.js", "l10n/**.json", "js/**.js.map", "js/**.js", "js/**.mjs", "js/**.mjs.map", "js/templates/**.handlebars", "screenshots/screenshot1.png", "src/assets/file-placeholder.svg"] | ||
| path = ["js/**.map"] | ||
| precedence = "override" |
Contributor
Author
There was a problem hiding this comment.
This is needed to remove warning from REUSE because there are SPDX headers within the map file (as they contain all sources).
It basically tells REUSE to use this license here instead of parsing the file.
artonge
approved these changes
Apr 23, 2025
skjnldsv
reviewed
Apr 23, 2025
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Still not sure about the benefits of 36 css files 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.