Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 23, 2025

Fix some Typescript issues I noticed while testing the other pull requests.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added the 3. to review Waiting for reviews label Apr 23, 2025
@susnux susnux requested a review from artonge April 23, 2025 12:48
@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 2.30%. Comparing base (279c59f) to head (7801c75).
Report is 128 commits behind head on master.

Files with missing lines Patch % Lines
src/views/TagContent.vue 0.00% 9 Missing ⚠️
src/views/UnassignedFaces.vue 0.00% 8 Missing ⚠️
src/views/Tags.vue 0.00% 4 Missing ⚠️
src/views/Timeline.vue 0.00% 4 Missing ⚠️
src/store/userConfig.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2963      +/-   ##
=========================================
- Coverage    2.31%   2.30%   -0.01%     
=========================================
  Files          98      98              
  Lines        6190    6193       +3     
  Branches      112     112              
=========================================
  Hits          143     143              
- Misses       6047    6050       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge
Copy link
Collaborator

artonge commented Apr 23, 2025

Might be merged after #2945. But don't want to have to deal with conflict for now :).

@susnux susnux closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants