Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Apr 24, 2025

Migration from manipulating "raw" WebDAV results to parsing them with resultToNode from @nextcloud/files.

Principal changes are:

  • Rewrite usages of node.filename to node.root + node.path
  • Access node attributes with node.attributes... instead of node...
  • Rewrite the store to prevent having to overload node objects with extra properties.
  • Consolidate store typing by:
    • typing vue.$store
    • dropping mapState, mapGetters, mapActions which were not typed and were messing with the components typing.
    • using this.$store... to access the state

I did some manual testing to fix most if not all the introduced issues. Cypress tests would have been appreciated, but I need to focus on new features now.

@artonge artonge self-assigned this Apr 24, 2025
@artonge artonge added 3. to review Waiting for reviews javascript Javascript related ticket technical debt Technical issue labels Apr 24, 2025
@artonge artonge added this to the Nextcloud 32 milestone Apr 24, 2025
@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.28%. Comparing base (1f8c96a) to head (999d49b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2968      +/-   ##
=========================================
- Coverage    2.31%   2.28%   -0.03%     
=========================================
  Files          98      97       -1     
  Lines        6190    6214      +24     
  Branches      112     111       -1     
=========================================
- Hits          143     142       -1     
- Misses       6047    6072      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge force-pushed the artonge/chore/migrate_to_node_api_2 branch 3 times, most recently from 90d061c to b9676bf Compare April 28, 2025 13:05
@artonge artonge requested review from skjnldsv and susnux April 28, 2025 13:23
@artonge artonge force-pushed the artonge/chore/migrate_to_node_api_2 branch from b9676bf to 1150d3b Compare April 29, 2025 14:30
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/chore/migrate_to_node_api_2 branch from 1150d3b to 999d49b Compare April 29, 2025 14:35
@artonge artonge merged commit 9e9bf80 into master Apr 29, 2025
46 of 47 checks passed
@artonge artonge deleted the artonge/chore/migrate_to_node_api_2 branch April 29, 2025 15:04
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews javascript Javascript related ticket technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants