-
-
Notifications
You must be signed in to change notification settings - Fork 77
chore: Migrate to Node API #2968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2968 +/- ##
=========================================
- Coverage 2.31% 2.28% -0.03%
=========================================
Files 98 97 -1
Lines 6190 6214 +24
Branches 112 111 -1
=========================================
- Hits 143 142 -1
- Misses 6047 6072 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
90d061c to
b9676bf
Compare
susnux
reviewed
Apr 29, 2025
susnux
reviewed
Apr 29, 2025
susnux
approved these changes
Apr 29, 2025
skjnldsv
approved these changes
Apr 29, 2025
b9676bf to
1150d3b
Compare
Signed-off-by: Louis Chemineau <[email protected]>
1150d3b to
999d49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
javascript
Javascript related ticket
technical debt
Technical issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from manipulating "raw" WebDAV results to parsing them with
resultToNodefrom@nextcloud/files.Principal changes are:
node.filenametonode.root + node.pathnode.attributes...instead ofnode...nodeobjects with extra properties.vue.$storemapState,mapGetters,mapActionswhich were not typed and were messing with the components typing.this.$store...to access the stateI did some manual testing to fix most if not all the introduced issues. Cypress tests would have been appreciated, but I need to focus on new features now.