Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented May 6, 2025

And add e2e tests

@artonge artonge self-assigned this May 6, 2025
@artonge artonge added javascript Javascript related ticket 2. developing Work in progress labels May 6, 2025
@artonge artonge added this to the Nextcloud 32 milestone May 6, 2025
@artonge artonge added the bug Something isn't working label May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 2.28%. Comparing base (d53bcaf) to head (ab78a03).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/views/PhotosTab.vue 0.00% 26 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3001   +/-   ##
======================================
  Coverage    2.27%   2.28%           
======================================
  Files         104     104           
  Lines        6364    6355    -9     
  Branches      118     118           
======================================
  Hits          145     145           
+ Misses       6215    6206    -9     
  Partials        4       4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge force-pushed the artonge/fix/sidebar branch from 30cac16 to f855ab4 Compare May 7, 2025 12:21
@artonge artonge marked this pull request as ready for review May 7, 2025 12:22
@artonge artonge added 3. to review Waiting for reviews regression Regression of a previous working feature and removed 2. developing Work in progress bug Something isn't working labels May 7, 2025
@artonge artonge force-pushed the artonge/fix/sidebar branch from f855ab4 to 5264cb2 Compare May 7, 2025 13:19
@artonge artonge requested review from skjnldsv and susnux May 7, 2025 13:52
@artonge artonge force-pushed the artonge/fix/sidebar branch 3 times, most recently from 03e326f to 2d77321 Compare May 7, 2025 19:31
@artonge artonge force-pushed the artonge/fix/sidebar branch from 2d77321 to 72d73c7 Compare May 15, 2025 08:41
@artonge artonge requested a review from susnux May 15, 2025 08:42
@artonge artonge force-pushed the artonge/fix/sidebar branch from 72d73c7 to 5a28e79 Compare May 15, 2025 20:28
@artonge artonge force-pushed the artonge/fix/sidebar branch from 5a28e79 to ab78a03 Compare May 15, 2025 20:30
@artonge artonge merged commit 20c2805 into master May 19, 2025
49 of 50 checks passed
@artonge artonge deleted the artonge/fix/sidebar branch May 19, 2025 13:38
@artonge
Copy link
Collaborator Author

artonge commented May 19, 2025

/backport to stable31

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 19, 2025
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label May 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews javascript Javascript related ticket regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants