chore: Apply rector php8.1 set #3018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/chore/rector
branch
from
e97b3a3 to
87c863e
Compare
artonge
force-pushed
the
artonge/chore/rector
branch
2 times, most recently
from
599946a to
351c16e
Compare
come-nc
reviewed
May 16, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
So weird that it’s refusing to use promoted constructor properties for some classe 🤔
Collaborator
Author
Maybe it's because there was already one? |
artonge
force-pushed
the
artonge/chore/rector
branch
from
228b22d to
b950c8e
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/chore/rector
branch
from
b950c8e to
924887d
Compare
come-nc
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Louis Chemineau [email protected]