fix: Set version number to stable and add migration to fix configvalues #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version of nextcloud/dialogs resulted in array instead of string in some config values. Add a migration to fix those. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/fix-incorrect-configvalue
branch
from
6230266 to
5f336b1
Compare
For a reason I do not understand the CI upgrades the coding standard to latest version before running, let’s apply it. Signed-off-by: Côme Chilliet <[email protected]>
Contributor
Author
|
I do not understand why in CI php-cs runs |
come-nc
requested review from
nickvergessen
and removed request for
artonge and
skjnldsv
susnux
approved these changes
Jun 24, 2025
Member
https://github.com/nextcloud/photos/blob/master/composer.json#L33 |
skjnldsv
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of nextcloud/dialogs resulted in array instead of string in some config values. Add a migration to fix those.
The bug itself was already fix when
nextcloud/dialogswas upgraded to 6.3.0. This fixes the database values for users which used the broken version.The migration is not needed on master as it’s a one-time fix and Nextcloud always upgrade to latest minor first before upgrade to a new major.