Skip to content

Conversation

@skjnldsv
Copy link
Member

  • Keep the sidebar opened if the only thing we did was closing the viewer
  • But close the sidebar if we clic another entry on the navigation

@skjnldsv skjnldsv self-assigned this Jul 28, 2025
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.29%. Comparing base (d509b63) to head (bc2a0f9).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3113      +/-   ##
=========================================
- Coverage    2.29%   2.29%   -0.01%     
=========================================
  Files         108     108              
  Lines        6405    6409       +4     
  Branches      122     122              
=========================================
  Hits          147     147              
- Misses       6253    6257       +4     
  Partials        5       5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skjnldsv skjnldsv force-pushed the fix/sidebar-close-nav-change branch from 597d7bd to 5e9e7b4 Compare July 28, 2025 07:05
@skjnldsv
Copy link
Member Author

/compile

@skjnldsv
Copy link
Member Author

/backport to stable31

@skjnldsv
Copy link
Member Author

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jul 28, 2025
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Jul 28, 2025
@skjnldsv skjnldsv requested a review from szaimen July 28, 2025 12:03
@szaimen szaimen removed their request for review July 28, 2025 12:05
@skjnldsv skjnldsv requested a review from susnux July 28, 2025 12:29
@skjnldsv skjnldsv merged commit d5312d0 into master Jul 28, 2025
49 of 51 checks passed
@skjnldsv skjnldsv deleted the fix/sidebar-close-nav-change branch July 28, 2025 12:30
@backportbot
Copy link

backportbot bot commented Jul 28, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/3113/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5e9e7b44 bc2a0f94

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3113/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Jul 28, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/3113/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5e9e7b44 bc2a0f94

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3113/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants