Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Aug 18, 2025

Fix #3126

Two questionable icons:

  • No outline for Albums icon in material design icon. Will ask if we have a solution to use the material symbols already
Screenshot From 2025-08-18 13-07-11
  • Should the star icon when favoriting be filled, and outlined when unfavoriting? @kra-mo any opinion?
Screenshot From 2025-08-18 13-07-05 Screenshot From 2025-08-18 13-07-00

@artonge artonge self-assigned this Aug 18, 2025
@artonge artonge added enhancement New feature or request design Related to the design javascript Javascript related ticket 2. developing Work in progress labels Aug 18, 2025
@artonge artonge added this to the Nextcloud 32 milestone Aug 18, 2025
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@4576c87). Learn more about missing BASE report.
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #3131   +/-   ##
========================================
  Coverage          ?   2.28%           
========================================
  Files             ?     108           
  Lines             ?    6441           
  Branches          ?     122           
========================================
  Hits              ?     147           
  Misses            ?    6289           
  Partials          ?       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge force-pushed the artonge/feat/outline_icons branch from b1dd3c4 to 5aa9412 Compare August 18, 2025 11:55
@AndyScherzinger
Copy link
Member

No outline for Albums icon in material design icon. Will ask if we have a solution to use the material symbols already

How about https://pictogrammers.com/library/mdi/icon/image-multiple-outline/ for the album?

Should the star icon when favoriting be filled, and outlined when unfavoriting? @kra-mo any opinion?

For Talk @jancborchardt and I decided it would reflect the state, so filled when favorited (-> "to unfav" action)

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Agree with @AndyScherzinger 's review. :)

Fix #3126

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/outline_icons branch from 5aa9412 to 3cee79c Compare August 18, 2025 13:19
@artonge artonge marked this pull request as ready for review August 18, 2025 13:24
@artonge artonge requested review from skjnldsv and susnux August 18, 2025 13:25
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 18, 2025
@artonge artonge merged commit ca0afbe into master Aug 18, 2025
49 checks passed
@artonge artonge deleted the artonge/feat/outline_icons branch August 18, 2025 13:47
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design enhancement New feature or request javascript Javascript related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🎨 Use outline icons

5 participants