Replace mdi download icon with Material Symbol variant #3147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3147 +/- ##
======================================
Coverage 2.24% 2.24%
======================================
Files 107 107
Lines 6509 6509
Branches 121 121
======================================
Hits 146 146
Misses 6358 6358
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
susnux
approved these changes
Sep 3, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
@AndyScherzinger can you run npm lint:fix locally?
Because the import order is now wrong.
AndyScherzinger
force-pushed
the
style/noid/downloadIcon
branch
2 times, most recently
from
ec85328 to
bea335d
Compare
Member
Author
|
/compile |
Member
Author
|
should be fixed now @susnux but have to do it manually, can run it locally on my windows setup |
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
AndyScherzinger
force-pushed
the
style/noid/downloadIcon
branch
from
bde6042 to
359806c
Compare
Member
Author
|
/compile amend |
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
style/noid/downloadIcon
branch
from
359806c to
882e2f0
Compare
Member
Author
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.