-
-
Notifications
You must be signed in to change notification settings - Fork 77
[stable31] Fix empty photos/people tab #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable31] Fix empty photos/people tab #3197
Conversation
|
Fix for #3105 |
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
/compile rebase |
|
@Marraz can you compile and commit the files ? |
|
@Marraz please remove the merge commit. If you want to update your branch, you can rebase it. :). |
0ee7d66 to
8ab3450
Compare
|
@artonge Done, let me know if there is something else missing |
Signed-off-by: Mario Moreno Meza <[email protected]>
Signed-off-by: Mario Moreno Meza <[email protected]>
Signed-off-by: Mario Moreno Meza <[email protected]>
4e6fa5e to
27c013a
Compare
|
Thank you @Marraz :) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
The tap does show the faces recognized but clicking in any of them doesn't show anything.
Can't go into master since it have been refactor.