Skip to content

Conversation

@Marraz
Copy link

@Marraz Marraz commented Sep 21, 2025

The tap does show the faces recognized but clicking in any of them doesn't show anything.
Can't go into master since it have been refactor.

@Marraz
Copy link
Author

Marraz commented Sep 21, 2025

Fix for #3105
This is already fix in master since this whole file was refactor so it shouldn't apply to v32

Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@artonge
Copy link
Collaborator

artonge commented Sep 22, 2025

/compile rebase

@artonge
Copy link
Collaborator

artonge commented Sep 22, 2025

@Marraz can you compile and commit the files ?

@artonge
Copy link
Collaborator

artonge commented Sep 22, 2025

@Marraz please remove the merge commit. If you want to update your branch, you can rebase it. :).

@Marraz Marraz force-pushed the fix/photos-faces-recognize branch from 0ee7d66 to 8ab3450 Compare September 22, 2025 15:58
@Marraz
Copy link
Author

Marraz commented Sep 22, 2025

@artonge Done, let me know if there is something else missing

Signed-off-by: Mario Moreno Meza <[email protected]>
Signed-off-by: Mario Moreno Meza <[email protected]>
@Marraz Marraz force-pushed the fix/photos-faces-recognize branch from 4e6fa5e to 27c013a Compare September 23, 2025 00:49
@artonge artonge merged commit 4e84fb4 into nextcloud:stable31 Sep 23, 2025
42 of 44 checks passed
@artonge
Copy link
Collaborator

artonge commented Sep 23, 2025

Thank you @Marraz :)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants