Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Oct 15, 2025

Cleaned version of #3216
Fix #3205

@artonge artonge requested review from skjnldsv and susnux October 15, 2025 12:58
@artonge artonge self-assigned this Oct 15, 2025
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Oct 15, 2025
@artonge artonge mentioned this pull request Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.22%. Comparing base (4e02930) to head (8ebe484).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3237      +/-   ##
=========================================
- Coverage    2.22%   2.22%   -0.01%     
=========================================
  Files         107     107              
  Lines        6556    6557       +1     
  Branches      121     121              
=========================================
  Hits          146     146              
- Misses       6405    6406       +1     
  Partials        5       5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: tegge <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@artonge artonge force-pushed the workaround_#3205_32.0.0 branch from e5074b8 to 8ebe484 Compare October 15, 2025 13:01
@artonge
Copy link
Collaborator Author

artonge commented Oct 15, 2025

/backport to stable32

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Oct 15, 2025
@artonge artonge added this to the Nextcloud 33 milestone Oct 15, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative: Do not import it at all. Its globally available when vue router is registered to Vue :)

@artonge
Copy link
Collaborator Author

artonge commented Oct 15, 2025

Alternative: Do not import it at all. Its globally available when vue router is registered to Vue :)

Good to know, thanks ! I think I prefer explicitly importing it.

@artonge artonge merged commit 24c782d into master Oct 15, 2025
47 checks passed
@artonge artonge deleted the workaround_#3205_32.0.0 branch October 15, 2025 13:40
@backportbot
Copy link

backportbot bot commented Oct 15, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/3237/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ebe484f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3237/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working javascript Javascript related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

People tab broken in Nextcloud 32

4 participants