-
-
Notifications
You must be signed in to change notification settings - Fork 77
fix(FacesView): Properly import RouterLink #3237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3237 +/- ##
=========================================
- Coverage 2.22% 2.22% -0.01%
=========================================
Files 107 107
Lines 6556 6557 +1
Branches 121 121
=========================================
Hits 146 146
- Misses 6405 6406 +1
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: tegge <[email protected]> Signed-off-by: Louis Chmn <[email protected]>
e5074b8 to
8ebe484
Compare
|
/backport to stable32 |
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative: Do not import it at all. Its globally available when vue router is registered to Vue :)
Good to know, thanks ! I think I prefer explicitly importing it. |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/3237/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ebe484f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3237/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Cleaned version of #3216
Fix #3205