Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Nov 13, 2025

No description provided.

@artonge artonge self-assigned this Nov 13, 2025
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket feature: albums Related to the albums section labels Nov 13, 2025
@artonge artonge added this to the Nextcloud 33 milestone Nov 13, 2025
@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/backport to stable32

@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/backport to stable31

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Nov 13, 2025
@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/backport to stable30

@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/backport to stable29

@artonge artonge requested review from skjnldsv and susnux November 13, 2025 16:36
@artonge artonge changed the title fix(Album): Prevent whitespace only album names fix(Album): Prevent whitespace-only album names Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.21%. Comparing base (dfac3fb) to head (3a063cf).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3285   +/-   ##
======================================
  Coverage    2.21%   2.21%           
======================================
  Files         107     107           
  Lines        6589    6589           
  Branches      121     121           
======================================
  Hits          146     146           
  Misses       6438    6438           
  Partials        5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge force-pushed the artonge/fix/whitespace_album_names branch from 042be72 to f6ce68b Compare November 13, 2025 21:53
@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge merged commit 29fa7ac into master Nov 13, 2025
46 checks passed
@artonge artonge deleted the artonge/fix/whitespace_album_names branch November 13, 2025 21:59
@backportbot
Copy link

backportbot bot commented Nov 13, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/3285/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f6ce68ba 3a063cf9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3285/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Nov 13, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/3285/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f6ce68ba 3a063cf9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3285/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Nov 13, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/3285/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f6ce68ba 3a063cf9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3285/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working feature: albums Related to the albums section javascript Javascript related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants