Skip to content

[stable29] fix(Album): Do not overwrite album on rename #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 4 commits into from
Nov 13, 2025
+18 −9
Merged

[stable29] fix(Album): Do not overwrite album on rename #3301

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5565e0
Revert "fix(albums): Do not overwrite albums on move"
artonge Nov 13, 2025
90a5e9d
fix(Album): [stable31] Do not overwrite album on rename
artonge Nov 13, 2025
fc0b491
chore(assets): Recompile assets
nextcloud-command Nov 13, 2025
dea2dee
chore(assets): Recompile assets
nextcloud-command Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/store/collections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,15 @@ const actions = {
filename: collection.filename.replace(new RegExp(`${collection.basename}$`), newBaseName),
}

try {
await client.stat(newCollection.filename)
logger.error(t('photos', 'Failed to rename {currentCollectionFileName} to {newCollectionFileName}', { currentCollectionFileName: collectionFileName, newCollectionFileName: newCollection.filename }), { error: new Error('Target collection already exists') })
showError(t('photos', 'Failed to rename {currentCollectionFileName} to {newCollectionFileName}', { currentCollectionFileName: collectionFileName, newCollectionFileName: newCollection.filename }))
return collection
} catch (error) {
// If the stat fails, it means that the target does not exist yet, so all good.
}

try {
context.commit('addCollections', { collections: [newCollection] })
context.commit('setCollectionFiles', { collectionFileName: newCollection.filename, fileIds: context.state.collectionsFiles[collectionFileName] })
Expand Down
Loading