Skip to content

[stable29] fix(Album): Prevent whitespace only album names #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
Nov 14, 2025
Merged

[stable29] fix(Album): Prevent whitespace only album names #3308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Albums/AlbumForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<form v-if="!showCollaboratorView" class="album-form" @submit.prevent="submit">
<div class="form-inputs">
<NcTextField ref="nameInput"
:value.sync="albumName"
v-model="albumName"
type="text"
name="name"
:helper-text="albumNameValidationError"
Expand Down Expand Up @@ -81,7 +81,7 @@
</span>
<span class="right-buttons">
<NcButton type="primary"
:disabled="albumName.trim() === '' || loading"
:disabled="!canSubmit"
@click="submit(collaborators)">
<template #icon>
<NcLoadingIcon v-if="loading" :size="20" />
Expand Down Expand Up @@ -213,7 +213,7 @@
methods: {
...mapActions(['createCollection', 'renameCollection', 'updateCollection']),

/** @param {import('../../store/albums.js').Collaborator[]} collaborators */

Check warning on line 216 in src/components/Albums/AlbumForm.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @param "collaborators" description
submit(collaborators = []) {
if (!this.canSubmit) {
return
Expand All @@ -226,7 +226,7 @@
}
},

/** @param {import('../../store/albums.js').Collaborator[]} collaborators */

Check warning on line 229 in src/components/Albums/AlbumForm.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @param "collaborators" description
async handleCreateAlbum(collaborators = []) {
try {
this.loading = true
Expand Down
Loading