Skip to content

Conversation

@Mikescops
Copy link
Member

@Mikescops Mikescops commented Oct 12, 2020

This is a fix for request #277.

It implements a new "Your videos" tab and the ability to filter a bit more mime types when requesting photos.

image

I'd like some guidance for the needed translation.

Also there is a limitation on array merge that is fix only on PHP7.4 with the spread operator.

@Mikescops Mikescops self-assigned this Oct 12, 2020
@Mikescops Mikescops added 2. developing Work in progress enhancement New feature or request labels Oct 12, 2020
@Mikescops Mikescops changed the title Implement "your video" tab Implement "your videos" tab Oct 12, 2020
@Mikescops Mikescops requested a review from skjnldsv October 12, 2020 19:23
@Mikescops
Copy link
Member Author

It is sightly different approach than #392, same limitations indeed.
Hope we can bring back the topic on the table.

@Mikescops
Copy link
Member Author

Done @skjnldsv

@Mikescops Mikescops added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 13, 2020
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks 👌 🚀

Signed-off-by: Corentin Mors <[email protected]>
@Mikescops Mikescops force-pushed the feature/implement-video-tab branch from 8bb1a5c to 3f7ea97 Compare October 14, 2020 16:03
@Mikescops
Copy link
Member Author

Rebased with latest master.

@Mikescops Mikescops merged commit 862110c into master Oct 14, 2020
@Mikescops Mikescops deleted the feature/implement-video-tab branch October 14, 2020 16:13
@jancborchardt
Copy link
Member

It’s still a bit strange to have the videos filtered if they show no previews at all. :\ Hope we still find a solution there, also ref the discussion from @jakobroehrl’s pull request in #392

@Mikescops
Copy link
Member Author

So I suggested an idea to @skjnldsv, when there is no preview, we display the name of the video in the tile. Also we can suggest with a banner a way to activate video previews

@jancborchardt
Copy link
Member

when there is no preview, we display the name of the video in the tile. Also we can suggest with a banner a way to activate video previews

Both nice enhancements! :) The banner should only show to admins though who can actually make the change.

@skjnldsv
Copy link
Member

@Mikescops can you open issues for those? :)

@Mikescops
Copy link
Member Author

#508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants