-
-
Notifications
You must be signed in to change notification settings - Fork 77
Implement "your videos" tab #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It is sightly different approach than #392, same limitations indeed. |
|
Done @skjnldsv |
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks 👌 🚀
Signed-off-by: Corentin Mors <[email protected]>
8bb1a5c to
3f7ea97
Compare
|
Rebased with latest master. |
|
It’s still a bit strange to have the videos filtered if they show no previews at all. :\ Hope we still find a solution there, also ref the discussion from @jakobroehrl’s pull request in #392 |
|
So I suggested an idea to @skjnldsv, when there is no preview, we display the name of the video in the tile. Also we can suggest with a banner a way to activate video previews |
Both nice enhancements! :) The banner should only show to admins though who can actually make the change. |
|
@Mikescops can you open issues for those? :) |
This is a fix for request #277.
It implements a new "Your videos" tab and the ability to filter a bit more mime types when requesting photos.
I'd like some guidance for the needed translation.
Also there is a limitation on array merge that is fix only on PHP7.4 with the spread operator.