[Regression Fix] Readd loading icon #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Corentin Mors <[email protected]>
skjnldsv
reviewed
Oct 13, 2020
skjnldsv
approved these changes
Oct 13, 2020
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Minor change request, good otherwise
Signed-off-by: Corentin Mors <[email protected]>
skjnldsv
requested changes
Oct 13, 2020
src/components/Loader.vue
Outdated
Comment on lines
2
to
4
| - @copyright Copyright (c) 2020 Nextcloud | ||
| - | ||
| - @license GNU AGPL version 3 or any later version |
Member
There was a problem hiding this comment.
Btw please also add yourself as the author for the other files you edited
Signed-off-by: Corentin Mors <[email protected]>
skjnldsv
approved these changes
Oct 14, 2020
Member
Author
Member
|
I thought it was on purpose so I could review 478 after 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for regression added by #468.
With the last vue-virtual-grid update we can set a loader component until the next batch is loaded.