Fully migrate to the new Virtual Grid #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikescops
added
3. to review
skjnldsv
reviewed
Oct 15, 2020
Member
|
/compile / |
skjnldsv
approved these changes
Oct 15, 2020
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Works nicely!! 🚀
Found one issue that doesn't seems related, missing padding on top of timeline
Member
Author
|
@skjnldsv that's a bug when we forget to reset the grid i think. |
Member
It happens on initial load for me 🤔 |
Member
Author
|
😨 what, not me... |
Member
Author
|
Can you force refresh the page? Maybe you got cache I don't know |
skjnldsv
force-pushed
the
feature/grid-migration
branch
2 times, most recently
from
c6e0735 to
f6d61ac
Compare
Member
Well, paddingTop is set to 0 Line 312 in f6d61ac |
Member
Author
|
You should have the first title of the month that do a padding, that's what we discussed with Jan, you likely don't have a title, so it should be an issue with the js |
Signed-off-by: Corentin Mors <[email protected]>
Mikescops
force-pushed
the
feature/grid-migration
branch
from
f6d61ac to
7a867da
Compare
This was referenced Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the last views and remove the old grid.