Skip to content

Fix wording squared photo view #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Oct 19, 2020
Merged

Fix wording squared photo view #500

skjnldsv merged 1 commit into from
Oct 19, 2020

Conversation

@Mikescops
Copy link
Member

@Mikescops Mikescops commented Oct 19, 2020

Closes #494

@Mikescops Mikescops added 3. to review Waiting for reviews papercut Small issues that doesn't break the ux/ui labels Oct 19, 2020
@Mikescops Mikescops requested a review from skjnldsv October 19, 2020 11:25
@Mikescops Mikescops self-assigned this Oct 19, 2020
@Mikescops
Copy link
Member Author

Mikescops commented Oct 19, 2020

/compile amend /

@npmbuildbot
Fix wording squared photo view
e4f925b 
Signed-off-by: Corentin Mors <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the bugfix/wording-square-layout branch from cd26cf4 to e4f925b Compare October 19, 2020 11:42
@skjnldsv skjnldsv merged commit 7303a4a into master Oct 19, 2020
@skjnldsv skjnldsv deleted the bugfix/wording-square-layout branch October 19, 2020 11:53
@rakekniven
Copy link
Member

rakekniven commented Oct 19, 2020

Thanks for the change. IMHO we need to change another word. See

photos/src/components/Settings/CroppedLayoutSettings.vue

Line 25 in e4f925b

<h2>{{ t('photos', 'Layout') }}</h2>

Layout -> View

@rakekniven rakekniven mentioned this pull request Oct 19, 2020
Closed
@Mikescops
Copy link
Member Author

Mikescops commented Oct 19, 2020

@rakekniven From my "french" perspective the word layout sounds better than view for what we are describing

@rakekniven
Copy link
Member

rakekniven commented Oct 20, 2020

Now we have two strings:
"Enable squared photos view" and "Layout".

That is not good in my opinion.

Can someone supply a screenshot of the UI, please?

@skjnldsv
Copy link
Member

skjnldsv commented Oct 20, 2020

What about Display ?
Affichage, Vue in french works fine.
The English string doesn't need to be literally translated. I would still aim for having the same wording like @rakekniven suggested for the sanity of our translators, but you can safely adjust View to Vue ou Rendu in french, context is important in translations anyway :)

@rakekniven
Copy link
Member

rakekniven commented Oct 20, 2020

At "Files" we have function "Toggle grid view" at top right.

@skjnldsv skjnldsv mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@Mikescops Mikescops

Labels

3. to review Waiting for reviews papercut Small issues that doesn't break the ux/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Translators need context for "Enable cropped layout"

4 participants

@Mikescops @rakekniven @skjnldsv