Skip to content

Add vue-virtual-grid to babel #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Mar 19, 2021
Merged

Add vue-virtual-grid to babel #709

skjnldsv merged 1 commit into from
Mar 19, 2021

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 19, 2021

Signed-off-by: John Molakvoæ (skjnldsv) [email protected]

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Mar 19, 2021
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 19, 2021

/compile amend /

@skjnldsv @npmbuildbot-nextcloud
Add vue-virtual-grid to babel
4c5de33 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/babel-vue-virtual-grid branch from baa83f8 to 4c5de33 Compare March 19, 2021 14:41
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 19, 2021 

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   js/photos-1.js
	modified:   js/photos-1.js.map
	modified:   js/photos-main.js
	modified:   js/photos-main.js.map

Yep, let's merge and fix it. Some browsers (FF ESR) are not compatible with some features of vue-virtual-grid (like spread).

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 19, 2021

/backport to stable21

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 19, 2021

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Mar 19, 2021
@skjnldsv skjnldsv merged commit 34114d5 into master Mar 19, 2021
@skjnldsv skjnldsv deleted the fix/babel-vue-virtual-grid branch March 19, 2021 14:42
This was referenced Mar 19, 2021
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skjnldsv