Fix Tags: Don't display tags without photos #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/compile amend /js |
nextcloud-command
force-pushed
the
fix/empty-tags
branch
from
80107dc to
c75970c
Compare
skjnldsv
force-pushed
the
fix/empty-tags
branch
from
c75970c to
50d3c47
Compare
skjnldsv
approved these changes
Jan 14, 2022
Member
|
Rebased |
Member
|
/compile amend / |
fixes #747 Signed-off-by: Marcel Klehr <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/empty-tags
branch
from
50d3c47 to
3c0ff29
Compare
skjnldsv
added
4. to release
Member
|
/backport to stable23 |
backportbot-nextcloud
bot
added
the
backport-request
Member
|
/backport to stable22 |
Member
|
/backport to stable21 |
This was referenced Jan 14, 2022
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, people will see tags that they don't use and haven't set on any of their files, which is confusing. This PR removes tags without photos from the view. As you can see in the screencast, this is kind of ugly, since the systemtags endpoint doesn't tell us how many items there are for each tag (AFAIK) before we're rendering the tags.
fixes #747 (YMMV)