Skip to content

[stable25] Replace custom tooltips with native ones #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Jan 30, 2023
Merged

[stable25] Replace custom tooltips with native ones #849

ChristophWurst merged 1 commit into from
Jan 30, 2023

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 26, 2023

backport of #848

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 26, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the base branch from master to stable25 January 26, 2023 10:14
@ChristophWurst ChristophWurst changed the title [stable25] Fix/835 replace custom tooltips with native one for privacy settings page stable25 [stable25] Replace custom tooltips with native ones Jan 26, 2023
skjnldsv
skjnldsv requested changes Jan 26, 2023
View reviewed changes
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 30, 2023

@JuliaKirschenheuter rebase the PR onto latest stable25. CI should then be picked up again. 🤞

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jan 30, 2023

/rebase

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jan 30, 2023

@JuliaKirschenheuter rebase the PR onto latest stable25. CI should then be picked up again. crossed_fingers

"/rebase" command should help here 🤞

@nextcloud-command nextcloud-command force-pushed the fix/835-Replace_custom_tooltips_with_native_one_for_privacy_settings_page-stable25 branch from cebff63 to 3ea13f4 Compare January 30, 2023 15:05
@ChristophWurst ChristophWurst merged commit e6d83b8 into stable25 Jan 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/835-Replace_custom_tooltips_with_native_one_for_privacy_settings_page-stable25 branch January 30, 2023 15:16
@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JuliaKirschenheuter @ChristophWurst @tobiasKaminsky @artonge @skjnldsv @Pytal