Skip to content

Add note to development setup docs about committing built files #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Dec 10, 2019
Merged

Add note to development setup docs about committing built files #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ The app is in incubation stage, so it’s time for you to [get involved! 👩‍
3. 🏗 To build the Javascript whenever you make changes, run `npm run dev`
4. ☁ Enable the app through the app management of your Nextcloud or run `krankerl enable`
5. 👍 Partytime! Help fix [some issues](https://github.com/nextcloud/recommendations/issues) and [review pull requests](https://github.com/nextcloud/recommendations/pulls)

Whenever you commit changes to submit a pull request, make sure to build the Javascript using `npm run build` and commit the files `js/*.js` and `js/*.js.map` as well. This needs to be done because the app is shipped with the release as is.