Skip to content

Add Recommendations Toggle #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gary-kim merged 1 commit into from
Mar 31, 2020
Merged

Add Recommendations Toggle #168

gary-kim merged 1 commit into from
Mar 31, 2020

Conversation

@gary-kim
Copy link
Member

@gary-kim gary-kim commented Dec 23, 2019 •
edited
Loading

Use the new OCA.Files.Settings API.

Resolves #72
Resolves #108

Signed-off-by: Gary Kim [email protected]

@gary-kim gary-kim added enhancement New feature or request 2. developing labels Dec 23, 2019
@gary-kim gary-kim added this to the Nextcloud 19 milestone Dec 23, 2019
@gary-kim gary-kim self-assigned this Dec 23, 2019
@gary-kim gary-kim force-pushed the enh/108/recommendations-toggle branch from c29f1ed to 2724a31 Compare December 23, 2019 15:57
@gary-kim gary-kim mentioned this pull request Dec 23, 2019
Merged
@gary-kim gary-kim force-pushed the enh/108/recommendations-toggle branch 3 times, most recently from 9d14e07 to 1597e0c Compare December 23, 2019 16:57
@jancborchardt
Copy link
Member

jancborchardt commented Mar 12, 2020

Just a sidenote, when testing this with the server pull request I get:

The files of the app Recommendations (recommendations) were not replaced correctly. Make sure it is a version compatible with the server.

Cause the max-version is 18 – setting to 19 fixes it. :)

jancborchardt
jancborchardt reviewed Mar 12, 2020
View reviewed changes
@gary-kim gary-kim force-pushed the enh/108/recommendations-toggle branch from 7d375a9 to e22a364 Compare March 13, 2020 06:30
jancborchardt
jancborchardt approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work, proper place for that setting :)

skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
src/main.js Outdated
}).$mount(this.el);

// register Files App Setting
const settingsView = new (Vue.extend(Settings))({
Copy link
Member

@skjnldsv skjnldsv Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still find this syntax super confusing :(

skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv reviewed Mar 13, 2020
View reviewed changes
skjnldsv
skjnldsv previously requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments ;)

Very nice work :)

@gary-kim gary-kim force-pushed the enh/108/recommendations-toggle branch from 757f34d to f6d9db2 Compare March 24, 2020 05:41
@gary-kim gary-kim force-pushed the enh/108/recommendations-toggle branch from f6d9db2 to 283bce3 Compare March 24, 2020 05:44
ChristophWurst
ChristophWurst reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

Is this a production build? +2,259 −861 seems a bit much 🤔

@gary-kim
Copy link
Member Author

gary-kim commented Mar 24, 2020 •
edited
Loading

Code looks good!

Is this a production build? +2,259 −861 seems a bit much thinking

It's from package-lock.json, this branch has been around for a while so it looks the like rebase got confused. Give me a sec.

EDIT: There we go.

@gary-kim gary-kim force-pushed the enh/108/recommendations-toggle branch from 283bce3 to 0e25e89 Compare March 24, 2020 08:57
ChristophWurst
ChristophWurst approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better :)

@gary-kim gary-kim force-pushed the enh/108/recommendations-toggle branch from 0e25e89 to 3c2c184 Compare March 24, 2020 09:04
@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 31, 2020

@gary-kim rebase
@gary-kim merge :P

@gary-kim gary-kim force-pushed the enh/108/recommendations-toggle branch from 3c2c184 to ee4ddf8 Compare March 31, 2020 12:26
@gary-kim gary-kim requested a review from skjnldsv March 31, 2020 12:26
@gary-kim gary-kim dismissed skjnldsv’s stale review March 31, 2020 14:02

Points addressed

@gary-kim gary-kim merged commit 2c80102 into master Mar 31, 2020
@gary-kim gary-kim deleted the enh/108/recommendations-toggle branch March 31, 2020 14:08
@szaimen
Copy link

szaimen commented Apr 1, 2020

Is this also configurable via occ for all users?

@kosssi
Copy link

kosssi commented Mar 31, 2021

@szaimen have you find a solution to disable recommendation by default ?

@szaimen
Copy link

szaimen commented Mar 31, 2021

No, no official solution but there are many workarounds:

  • hide the section with the custom_css app
  • build a script that loops over all users and sets the correct user-setting to disable it
  • disable the recommendations app

@corpix
Copy link

corpix commented Apr 23, 2025

this PR appeared in google when I searched for a way to disable recommendations. After reading PR have no idea how should I disable recommendations, probably something changed, so done this a barbarian way via Nginx configuration:

location = /ocs/v2.php/apps/recommendations/api/v1/recommendations {
    return 200 "{\"ocs\":{\"meta\":{\"status\":\"ok\",\"statuscode\":200,\"message\":\"OK\"},\"data\":{\"enabled\":false,\"recommendations\":[]}}}";
    default_type application/json;
}

would save me some CPU cycles 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@gary-kim gary-kim

Labels

4. to release enhancement New feature or request

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

Recommendations toggle in bottom left Files settings Show / Hide Recommendations View

8 participants

@gary-kim @jancborchardt @ChristophWurst @szaimen @kosssi @corpix @skjnldsv