Skip to content

[stable20] FIx loading speed of dashboard by loading the data async #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 3 commits into from
Oct 7, 2020
Merged

[stable20] FIx loading speed of dashboard by loading the data async #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cd33a2
FIx loading speed of dashboard by loading the data async
nickvergessen Sep 23, 2020
8e417bf
Remove initial state parsing from frontend code
juliusknorr Oct 7, 2020
c3fac0d
Compile assets
npmbuildbot[bot] Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions js/dashboard.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/dashboard.js.map
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions js/main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions lib/Dashboard/RecommendationWidget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@ public function load(): void {
if ($user === null) {
return;
}
$this->initialStateService->provideInitialState('recommendations', 'recommendations', [
'enabled' => true,
'recommendations' => $this->recommendationService->getRecommendations($user)
]);
Util::addScript('recommendations', 'dashboard');
}
}
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"homepage": "https://github.com/ChristophWurst/files_recommendation#readme",
"dependencies": {
"@nextcloud/axios": "^1.4.0",
"@nextcloud/initial-state": "^1.1.2",
"@nextcloud/router": "^1.2.0",
"@nextcloud/vue": "^2.6.1",
"@nextcloud/vue-dashboard": "^0.1.8",
Expand Down
8 changes: 1 addition & 7 deletions src/store/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import Vuex from 'vuex'
import axios from '@nextcloud/axios'
import { generateUrl } from 'nextcloud-server/dist/router'
import { fetchRecommendedFiles } from '../service/RecommendationService'
import { loadState } from '@nextcloud/initial-state'

Vue.use(Vuex)

Expand Down Expand Up @@ -75,12 +74,7 @@ export default new Vuex.Store({
return
}
this.commit('loading', true)
let fetched
try {
fetched = loadState('recommendations', 'recommendations')
} catch (e) {
fetched = await fetchRecommendedFiles()
}
const fetched = await fetchRecommendedFiles()

context.commit('enabled', fetched.enabled)
if (fetched.recommendations) {
Expand Down