Refactor php 7.4 #513
Merged
Refactor php 7.4 #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Schwan <[email protected]>
This is required so that I can run it locally Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
refactor-74
branch
5 times, most recently
from
4c6f178 to
7021421
Compare
Member
Author
|
@skjnldsv @ChristophWurst I ended up updating composer and the ci jobs. The list of required ci checks needs to be changed in the github setting. |
come-nc
approved these changes
May 5, 2022
CarlSchwan
force-pushed
the
refactor-74
branch
3 times, most recently
from
d382d5c to
15be7bf
Compare
nickvergessen
requested changes
May 9, 2022
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Installing fails on 7.4
Signed-off-by: Carl Schwan <[email protected]>
Member
Author
works for me with both 7.4 and 8.1 locally |
Member
You have permission to adjust the requried checks ✌️ |
ChristophWurst
approved these changes
May 9, 2022
nickvergessen
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.