Skip to content

Make compatible with Nextcloud 16 only #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 2 commits into from
Mar 12, 2019
Merged

Make compatible with Nextcloud 16 only #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1895b86
Require Nextcloud 16
ChristophWurst Mar 12, 2019
e1d72c6
Use php7.1+ features
ChristophWurst Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
<namespace>Recommendations</namespace>
<category>office</category>
<dependencies>
<php min-version="7.0" max-version="7.3"/>
<nextcloud min-version="15" max-version="16"/>
<php min-version="7.1" max-version="7.3"/>
<nextcloud min-version="16" max-version="16"/>
</dependencies>
<commands>
<command>\OCA\Recommendations\Command\GetRecommendations</command>
Expand Down
2 changes: 1 addition & 1 deletion lib/AppInfo/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

class Application extends App {

const APP_ID = 'recommendations';
public const APP_ID = 'recommendations';

public function __construct(array $urlParams = []) {
parent::__construct(self::APP_ID, $urlParams);
Expand Down
2 changes: 1 addition & 1 deletion lib/Service/IRecommendation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function getTimestamp(): int;

public function getNode(): Node;

public function hasPreview();
public function hasPreview(): bool;

public function setHasPreview(bool $state);

Expand Down
2 changes: 1 addition & 1 deletion lib/Service/RecommendationService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

class RecommendationService {

const MAX_RECOMMENDATIONS = 5;
private const MAX_RECOMMENDATIONS = 5;

/** @var IRecommendationSource */
private $sources;
Expand Down
2 changes: 1 addition & 1 deletion lib/Service/RecommendedFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function getReason(): string {
return $this->reason;
}

public function hasPreview() {
public function hasPreview(): bool {
return $this->hasPreview;
}

Expand Down