Skip to content

groupfolders support #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArtificialOwl merged 6 commits into from
May 17, 2023
Merged

groupfolders support #225

ArtificialOwl merged 6 commits into from
May 17, 2023

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented May 7, 2023 •
edited by AndyScherzinger
Loading

  • when browsing files, adding groupfolders' groups/circles to list of shares recipient if current file is in groupfolder when searching for related resources
  • returns groupfolder as related resources when browsing related items
  • generate link to the correct groupfolder
  • front-end ?

@ArtificialOwl ArtificialOwl mentioned this pull request May 7, 2023
Closed
@ArtificialOwl
groupfolders support
39744bb 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl force-pushed the support-groupfolders branch from 8012228 to 39744bb Compare May 8, 2023 12:46
@ArtificialOwl ArtificialOwl marked this pull request as ready for review May 12, 2023 09:37
@ArtificialOwl
fix test
1f0fa20 
Signed-off-by: Maxence Lange <[email protected]>
@AndyScherzinger
Copy link
Member

AndyScherzinger commented May 13, 2023

2 UI aspects that need polishing:

2023-05-12 11_38_31
  • related resources items should be left aligned not centered
  • related resources item icons for a circle is not properly dark/light themed like the other icons/avatars

@Pytal can you take care of this one, priority is higher then A11Y since we would need this for RC1

@AndyScherzinger AndyScherzinger added this to the Nextcloud 27 milestone May 13, 2023
@AndyScherzinger AndyScherzinger added 2. developing Work in progress enhancement New feature request labels May 13, 2023
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented May 14, 2023

can we review, merge and implements modification to front-end in another PR ?

@AndyScherzinger
Copy link
Member

AndyScherzinger commented May 14, 2023

Yes, absolutely 👍

come-nc
come-nc reviewed May 15, 2023
View reviewed changes
@Pytal
Fix groupfolder icon color
0d46b22 
Signed-off-by: Christopher Ng <[email protected]>
This was referenced May 15, 2023
Merged
Closed
@artonge
Copy link

artonge commented May 16, 2023

ℹ️ Front-end work was merged into this branch

@come-nc
Improve a bit typing
ac6e52a 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Copy link
Contributor

come-nc commented May 16, 2023

Good for me, waiting for CI

@ArtificialOwl
catch exception on missing icon
cc6ddb3 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl merged commit 9e6e9c0 into master May 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the support-groupfolders branch May 17, 2023 08:00
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc approved these changes

Assignees

@ArtificialOwl ArtificialOwl

@Pytal Pytal

Labels

2. developing Work in progress enhancement New feature request

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

6 participants

@ArtificialOwl @AndyScherzinger @artonge @come-nc @Pytal