Skip to content

Conversation

@tintou
Copy link
Contributor

@tintou tintou commented Feb 3, 2021

Summary

Adds missing supported types

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Fixes nextcloud#1341

Signed-off-by: Corentin Noël <[email protected]>
@timar timar mentioned this pull request Feb 4, 2021
@juliusknorr
Copy link
Member

Did you add some custom mimetype mapping to your nextcloud instance when testing this. As far as I see we currently cannot detect the flat odf mimetype properly within Nextcloud server and using mimetype detection on such a file itself at least for me always brings up text/xml for fodt files.

@juliusknorr
Copy link
Member

Pushed a server pull request to make this work properly nextcloud/server#29157

@tintou Could you maybe rebase your branch against current master and push again to trigger the tests again?

@juliusknorr juliusknorr added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels Oct 11, 2021
@juliusknorr juliusknorr added this to the 5.0.0 milestone Oct 11, 2021
@juliusknorr
Copy link
Member

@tintou Could you maybe rebase your branch to current master to run the tests again?

@juliusknorr
Copy link
Member

I've created a rebase version of your pr in #1811 so we can get this in for Nextcloud 23 (which is required due to the server dependency on the mimetypes nextcloud/server#29157)

@juliusknorr
Copy link
Member

Thanks a lot for your pull request and we'll get your commit there merged with the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Flat ODF files

2 participants