Basic draw support #1470
Merged
Basic draw support #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancborchardt
approved these changes
Oct 11, 2021
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Icon looks good for Draw actually :)
juliusknorr
added
3. to review
julien-nc
requested changes
Nov 8, 2021
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Code LGTM.
Code formatting suggestions are just small details 😁.
It runs fine.
- Preview are generated
- Document creation works fine
- Loading an existing document works fine
- ODG icon looks good
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
added
4. to release
Member
Author
|
Code style issues all resolved, we should also introduce https://github.com/FriendsOfPHP/PHP-CS-Fixer here |
julien-nc
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to bring in draw support for Collabora Online. (fixes #1450)
@jancborchardt Could you maybe help out a bit with some proper icon for the new file type, I quickly drafted something like this but maybe you can come up with a better idea or more polished one:
ToDo:
FYI @timar @eszkadev