Skip to content

Use native font stack in collabora #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Oct 4, 2021
Merged

Use native font stack in collabora #1774

juliusknorr merged 1 commit into from
Oct 4, 2021

Conversation

@luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Sep 21, 2021

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@luka-nextcloud luka-nextcloud self-assigned this Sep 21, 2021
@luka-nextcloud luka-nextcloud added the 3. to review Ready to be reviewed label Sep 21, 2021
@jancborchardt
Copy link
Member

jancborchardt commented Sep 21, 2021

@luka-nextcloud for pull requests which change something visual, can you add screenshots (e.g. before and after) for easier design review? Thanks a lot! :)

@jancborchardt jancborchardt linked an issue Sep 28, 2021 that may be closed by this pull request
Use native font stack within Collabora #1742
Closed
@luka-nextcloud
Copy link
Contributor Author

luka-nextcloud commented Sep 28, 2021

@jancborchardt Before my update, collabora's font was Segoe UI',Tahoma,Arial,Helvetica,sans-serif but now it's overwritten by -apple-system, BlinkMacSystemFont, Segoe UI, Roboto, Oxygen-Sans, Cantarell, Ubuntu, Helvetica Neue, Arial, Noto Color Emoji, sans-serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbo

image

image

image

jancborchardt
jancborchardt approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much better!

@juliusknorr juliusknorr merged commit 26ddaea into master Oct 4, 2021
@juliusknorr juliusknorr deleted the use-native-font-stack-in-collabora branch October 4, 2021 08:57
@juliusknorr juliusknorr mentioned this pull request Nov 10, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@luka-nextcloud luka-nextcloud

Labels

3. to review Ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use native font stack within Collabora

4 participants

@luka-nextcloud @jancborchardt @juliusknorr