-
Notifications
You must be signed in to change notification settings - Fork 140
url-encode filename when constructing the iframe url for the viewer #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I didn't find any instructions for contributing, so I hope it's fine just to send the PR like this. I see the complaint about signing off the commit, but I'm assuming an actual project member should sign-off and not me? Please let me know if I need to do something else. |
|
Thanks for your contribution. About the failing DCO, you may want to checkout the details at https://probot.github.io/apps/dco/ This can be fixed by adding a |
|
Btw. the ticket you linked seems to be unrelated, maybe there was a mistake with that? |
This fixes the problem mentioned [here](nextcloud/server#24618): when trying to open a document from the dashboard in a Folder with special characters like `&` or `+`, the viewer shows an error. Signed-off-by: Lu Fennell <[email protected]>
|
Oh.. yes the link was totally wrong. It's nextcloud/server#24618 I wanted to link to. I fixed it. I also signed of the commit, now. Thanks for the explanation |
|
/backport to stable22 |
|
/backport to stable3.8 |
|
The backport to stable3.8 failed. Please do this backport manually. |
|
/backport to stable4 |
|
Right 3.8 doesn't have viewer integration |
This fixes the problem mentioned
here: when trying to
open a document from the dashboard in a Folder with special characters
like
&or+, the viewer shows an error.Summary
Checklist