Skip to content

Conversation

@lu-fennell
Copy link

@lu-fennell lu-fennell commented Oct 16, 2021

This fixes the problem mentioned
here: when trying to
open a document from the dashboard in a Folder with special characters
like & or +, the viewer shows an error.

  • Resolves: #
  • Target version: master

Summary

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@lu-fennell
Copy link
Author

I didn't find any instructions for contributing, so I hope it's fine just to send the PR like this.

I see the complaint about signing off the commit, but I'm assuming an actual project member should sign-off and not me?

Please let me know if I need to do something else.

@juliusknorr
Copy link
Member

Thanks for your contribution. About the failing DCO, you may want to checkout the details at https://probot.github.io/apps/dco/ This can be fixed by adding a Signed-off-by messaage to the commit. You can easly amend that to the existing one using git commit --amend --signoff

@juliusknorr juliusknorr added 2. developing Work in progress bug Something isn't working labels Oct 19, 2021
@juliusknorr
Copy link
Member

Btw. the ticket you linked seems to be unrelated, maybe there was a mistake with that?

This fixes the problem mentioned
[here](nextcloud/server#24618): when trying to
open a document from the dashboard in a Folder with special characters
like `&` or `+`, the viewer shows an error.

Signed-off-by: Lu Fennell <[email protected]>
@lu-fennell
Copy link
Author

Oh.. yes the link was totally wrong. It's nextcloud/server#24618 I wanted to link to. I fixed it.

I also signed of the commit, now. Thanks for the explanation

@juliusknorr juliusknorr added 4. to release Ready to release, can be waiting for the tests to finish and removed 2. developing Work in progress labels Oct 19, 2021
@juliusknorr juliusknorr merged commit 7d930d8 into nextcloud:master Oct 25, 2021
@juliusknorr
Copy link
Member

/backport to stable22

@juliusknorr
Copy link
Member

/backport to stable3.8

@backportbot-nextcloud
Copy link

The backport to stable3.8 failed. Please do this backport manually.

@juliusknorr
Copy link
Member

/backport to stable4

@juliusknorr
Copy link
Member

Right 3.8 doesn't have viewer integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to release, can be waiting for the tests to finish bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants