Prevent download on user shares

[julien-nc]

Depends on nextcloud/server#32482
Implements #2267

Set the hideDownload attribute of the Wopi token when it's created. Get this from the share permissions. If multiple shares give access to the file, only one with download disabled will lead to hiding it in Collabora.

• Fix label for allow download share permission server#33448

[Raudius]

LGTM :)

[PVince81]

would this also apply for documents accessible through public link share ?
note that in this case there's the "hide download" option already, which is stored in a different field. maybe that logic exists already

[julien-nc]

@PVince81 Yes it already exists for public link shares: The view-only mode is enabled according to the "hide download" share attribute.

Will the download permission be relevant in public shares? I mean, do we need to adapt the way we enable the view-only mode for public shares so that we check the "hide download" value AND the download permission?

[PVince81]

@eneiluj you don't need to adapt it then. When resharing with a public link, the download permission is converted to "hide download" to be able to benefit from existing logic.

the perm from the share attributes is only intended for local shares.

[juliusknorr]

/backport to stable24

[juliusknorr]

• Needs another full test round after server PR is merged now

[CarlSchwan]

Server PR is merged for master, I'm in the progress of backporting it

[juliusknorr]

• We should make sure this also works if getAttributes is not available in case stable24 is not updated yet to the back ported version