[stable27] Version support and iframe refactoring #3172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
backport/3152/stable27
branch
from
2e7e3fd to
d54a2b4
Compare
23 failed tests on run #613 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
juliusknorr
force-pushed
the
backport/3152/stable27
branch
2 times, most recently
from
59321ac to
94b6d4e
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
backport/3152/stable27
branch
from
94b6d4e to
6f5ce84
Compare
juliusknorr
requested review from
blizzz,
luka-nextcloud,
max-nextcloud and
mejo-
juliusknorr
added
enhancement
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
backport/3152/stable27
branch
from
6f5ce84 to
2f5e3dd
Compare
mejo-
reviewed
Sep 12, 2023
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
The original PR added @nextcloud/paths to package.json. Don't know if this went missing here or whether it's unneeded 🤔
Member
Author
|
Ouh, seem i pushed that to the branch directly by accident 6a867be 🙈 |
mejo-
approved these changes
Sep 13, 2023
Member
|
Cypress failures look unrelated, but maybe you can take another look @juliushaertl? I just triggered a re-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3152