feat: add preview provider for emf files #3303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
added
enhancement
kesselb
requested review from
ChristophWurst,
juliusknorr and
luka-nextcloud
juliusknorr
reviewed
Nov 20, 2023
lib/AppInfo/Application.php
Outdated
| 'getPathForToken', | ||
| 'getWopiForToken', | ||
| ]); | ||
| $context->registerPreviewProvider(EMF::class, '/image\/emf/'); |
Member
There was a problem hiding this comment.
Did you give that a test with a Collabora intance setup? We have not migrated our preview class to the IProviderV2 interface (which we really should 🙈 ) and as far as I see it the context registration requires that.
Contributor
Author
There was a problem hiding this comment.
Did you give that a test with a Collabora intance setup?
Yep, it works like a charm ;)
the context registration requires that.
True, the psalm-param type hints IProviderV2.
I guess it's better to use the deprecated way that expects a IProvider instance for now.
Member
There was a problem hiding this comment.
Yep, let's stick to that then for now
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
juliusknorr
approved these changes
Nov 20, 2023
Contributor
Author
|
Documentation: nextcloud/documentation#11292 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For nextcloud/files_emfviewer#1
In addition to nextcloud/server#41395
We added support for image/emf via LibreOffice for 28.
For setups already using Richdocuments/Collabora it's nicer to let the previews generate via collabora web and no local LibreOffice installation is required.
TODO
Checklist