Skip to content

Improve setup checks and url handling with separate callback url #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 5 commits into from
Dec 1, 2023
Merged

Improve setup checks and url handling with separate callback url #3315

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae8e248
fix: Properly handle internal urls
juliusknorr Nov 23, 2023
6db3aa5
chore: Update psalm baseline with missing symfony dependencies
juliusknorr Nov 23, 2023
7a97213
feat: Add browser connectivity check
juliusknorr Nov 23, 2023
a9e8ee8
tests: Fix selectors on settings tests
juliusknorr Nov 23, 2023
4aecf93
fix: Convert CSP idn domains to ascii (fix #3086)
juliusknorr Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Update psalm baseline with missing symfony dependencies 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Nov 24, 2023
commit 6db3aa501dfde42d133f762c6552c8c7e51daf27
12 changes: 12 additions & 0 deletions tests/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@
<code><![CDATA[$app !== '']]></code>
</RedundantCondition>
</file>
<file src="lib/Controller/SettingsController.php">
<UndefinedClass>
<code>NullOutput</code>
<code>NullOutput</code>
</UndefinedClass>
</file>
<file src="lib/Controller/TemplatesController.php">
<InvalidReturnStatement>
<code><![CDATA[$this->fetchPreview($template, $x, $y, $a, $forceIcon, $mode)]]></code>
Expand Down Expand Up @@ -114,6 +120,12 @@
<code>Office</code>
</MissingDependency>
</file>
<file src="lib/Service/ConnectivityService.php">
<UndefinedClass>
<code>OutputInterface</code>
<code>OutputInterface</code>
</UndefinedClass>
</file>
<file src="lib/Service/FederationService.php">
<TypeDoesNotContainType>
<code>is_array($trustedList)</code>
Expand Down