Skip to content

[stable30] Pass data to field depending on field type #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 9 commits into from
Aug 29, 2024
Merged

[stable30] Pass data to field depending on field type #3954

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
57b8333
feat(tests): add testing for template filling workflow
elzody Aug 6, 2024
16b90ee
fix(templates): throw `NotFoundException` if no file returned by id
elzody Aug 15, 2024
e7bf89f
feat(template): make template handling more generic to support other …
elzody Aug 15, 2024
4ca08be
chore(ocp): Update nextcloud/ocp
juliusknorr Aug 28, 2024
2872792
fix: Adapt pdf service to new field api
juliusknorr Aug 28, 2024
f37c709
fix: Catch InvalidFieldTypeException
juliusknorr Aug 28, 2024
621ca56
fix: Check for mimetype before processing new file from template
juliusknorr Aug 29, 2024
de7ff74
fix: Avoid double checking the file
juliusknorr Aug 29, 2024
ea4ff1f
style: Apply php-cs fixes
juliusknorr Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Avoid double checking the file 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Aug 29, 2024
commit de7ff749605d0dbe034ab213dd0aaa11da10661b
8 changes: 4 additions & 4 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions lib/Service/TemplateFieldService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,6 @@ public function fillFields(Node|int $file, array $fields = [], ?string $destinat

if (is_int($file)) {
$file = $this->rootFolder->getFirstNodeById($file);

if (!$file) {
$e = new NotFoundException();
$this->logger->error($e->getMessage());

throw $e;
}
}

if (!$file || !$file instanceof File) {
Expand Down