Skip to content

fix: document created in wrong location on public share #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elzody merged 5 commits into from
Nov 19, 2025
Merged

fix: document created in wrong location on public share #5186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f92301
chore: remove new file entry workaround
elzody Nov 19, 2025
71cde2d
fix: allow new file menu on public shares
elzody Nov 19, 2025
2006bc3
feat(test): add test coverage
elzody Nov 19, 2025
f568809
fix: adjust boolean logic
elzody Nov 19, 2025
c41ba04
fix(test): more specificity
elzody Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: adjust boolean logic 
Signed-off-by: Elizabeth Danzberger <[email protected]>
  • Loading branch information
@elzody
elzody committed Nov 19, 2025
commit f5688096499be8799a39fb15f32725627c5a00db
2 changes: 1 addition & 1 deletion lib/Listener/RegisterTemplateFileCreatorListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function handle(Event $event): void {
}

$user = $this->permissionManager->loggedInUser();
$userCanCreate = $this->permissionManager->isEnabledForUser($user) || $this->permissionManager->userCanEdit($user);
$userCanCreate = $this->permissionManager->isEnabledForUser($user) && $this->permissionManager->userCanEdit($user);
if ($user && !$userCanCreate) {
return;
}
Expand Down
1 change: 1 addition & 0 deletions tests/lib/Listener/RegisterTemplateFileCreatorListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ public function testHandleRegistersWithoutDrawSupport() {
public function testHandleDoesNotRegisterIfUserCannotEdit() {
$event = $this->createMock(RegisterTemplateCreatorEvent::class);
$event->method('getTemplateManager')->willReturn($this->templateManager);
$this->permissionManager->method('loggedInUser')->willReturn('user');
$this->permissionManager->method('isEnabledForUser')->willReturn(true);
$this->permissionManager->method('userCanEdit')->willReturn(false);
$this->capabilitiesService->method('getCapabilities')->willReturn(['something']);
Expand Down
Loading